[MonoDevelop] Key Bindings patch

Jeffrey Stedfast fejj at novell.com
Mon Jul 16 11:55:53 EDT 2007

On Mon, 2007-07-16 at 13:43 +0200, Lluis Sanchez wrote:
> Hi!
> In general the changes look ok to me, just a few comments:
>       * I think it would be more memory efficient to have a single
>         KeyBindingChanged event in CommandManager, instead of having one
>         event per command. Commands might fire this event through an
>         internal method in CommandManager.


>       * The command manager should take into account that an application
>         may have several top level windows, and shortcuts should work in
>         all of them. In MD it may happen if the user detaches a pad into
>         a floating window.

I'll make sure this works and fix it if it doesn't, thanks for pointing
this out :)

>       * About "FIXME: figure out which of the commands to run based on
>         active widget?". The command manager should try to execute every
>         command with DispatchCommand, and stop when one of those calls
>         succeeds (returns true).

awesome, I was wondering about this as I was kayaking Saturday
morning ;)

>       * DispatchCommandFromAccel is probably not needed anymore.

Nod, altho it may be needed for commands which require a data item? From
what I could tell, we don't seem to have any of those type commands with
assigned key bindings currently, they all seem to simply have the 1-#
shortcuts once their sub-menu is opened... but I'm not 100% positive on
that ;)


More information about the Monodevelop-list mailing list