[MonoDevelop] Key Bindings patch

[Lluis Sanchez]

Hi!

In general the changes look ok to me, just a few comments:

      * I think it would be more memory efficient to have a single
        KeyBindingChanged event in CommandManager, instead of having one
        event per command. Commands might fire this event through an
        internal method in CommandManager.
      * The command manager should take into account that an application
        may have several top level windows, and shortcuts should work in
        all of them. In MD it may happen if the user detaches a pad into
        a floating window.
      * About "FIXME: figure out which of the commands to run based on
        active widget?". The command manager should try to execute every
        command with DispatchCommand, and stop when one of those calls
        succeeds (returns true).
      * DispatchCommandFromAccel is probably not needed anymore.

Lluis.

El dv 13 de 07 del 2007 a les 17:24 -0400, en/na Jeffrey Stedfast va
escriure:
> This is the result of my merging my backend keybinding changes with
> Balaji's OptionPanel patch + a number of alterations I've made to the
> OptionPanel.
> 
> Sending it here because I don't have time to commit it before I head out
> for the weekend and figured I'd post it here so Balaji was kept
> up-to-date with the key binding stuff :)
> 
> There's still some stuff left to do... the main things are:
> 
> 1. Implement a KeyBindingService class which can:
>   a) load key-binding templates (and knows where to find them)
>   b) list available key-binding templates
>   c) save user's config'd key-bindings(?), probably to
> ~/.config/MonoDevelop/KeyBindings.xml?
>   d) load KeyBindings.xml
> 
> 2. probably have the code that loads addin commands query the
> KeyBindingService for what the keybinding should be on a per-command
> basis as it loads the addin.xml files...
> 
> 3. Implement the TODO's (some are already kinda roughed out) in
> KeyBindingsPanel.cs
> 
> 
> Also... need Lluis to comment on CommandManager.cs changes, not sure my
> changes are correct (tho it does seem to work).
> 
> Jeff
> 
> _______________________________________________
> Monodevelop-list mailing list
> Monodevelop-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/monodevelop-list