[Mono-winforms-list] [PATCH] ListView sorting fixes

[Mike Kestner]

On Tue, 2006-08-29 at 21:42 +0200, Gert Driesen wrote:

> The bugs I came across in MS.NET are:
> - .NET 1.1: once set, modifying Sorting does not have any effect for
> SmallIcon and LargeIcon views unless a custom IComparer is set. This is
> fixed in .NET 2.0.
> - .NET 2.0: setting Sorting to None also discards the custom IComparer,
> if set.

Heh.  Nice detective work.  We might as well maintain bug compat on this
stuff.

> Is it ok to send patches to this list or should they go to the
> devel-list ?

This list is fine for patches.

This is beautiful work.  Thanks for providing such a detailed test suite
in addition to the code.

Comments:

- Considerable whitespace change in the beginning of the patch.  Please
try to remove as much of that as possible.
- Test bug79076 never Asserts or has no Exception expected attr.  What
is it testing?
- In the ItemComparer, the coding standard for fields would indicate
'sort_order', not '_sortOrder'.
- AFAICT, the two instances where Sort (false) occurs are immediately
followed by a call to Redraw.  So other than the overloading conflict
issue is there a reason for the redraw parameter on that new Sort
overload?

-- 
Mike Kestner  <mkestner at novell.com>
SUSE® Linux Enterprise 10
Your Linux is ready™
www.novell.com/linux