[Mono-winforms-list] [PATCH] ListView sorting fixes

[Gert Driesen]

Hi,

I've attached a patch that fixes some issues in the way sorting was
implemented for ListView.

All changes are accompanied by unit tests that pass in Mono 1.0/2.0 and
MS.NET 1.1/2.0.

I made my changes bug-compatible with MS as I think it's the only way to
ensure our implementations keep matching non-bug changes in MS.NET in
the near future. But this is just my opinion. Of course there are limits
to this bug-compatibility, but in this case they don't cause much harm.

The bugs I came across in MS.NET are:
- .NET 1.1: once set, modifying Sorting does not have any effect for
SmallIcon and LargeIcon views unless a custom IComparer is set. This is
fixed in .NET 2.0.
- .NET 2.0: setting Sorting to None also discards the custom IComparer,
if set.

Is it ok to send patches to this list or should they go to the
devel-list ?

If you want me to submit a bug report (with repro), just let me know.

Gert

PS. Don't be alarmed by the size of the patch, most of it are unit
tests ;-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: listview-sort.patch
Type: text/x-patch
Size: 54099 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-winforms-list/attachments/20060829/e95a374b/attachment-0001.bin