[Mono-winforms-list] [PATCH] ListView sorting fixes

[Mike Kestner]

On Thu, 2006-08-31 at 11:41 -0500, Mike Kestner wrote:

> Comments:
> 
> - Considerable whitespace change in the beginning of the patch.  Please
> try to remove as much of that as possible.
> - Test bug79076 never Asserts or has no Exception expected attr.  What
> is it testing?
> - In the ItemComparer, the coding standard for fields would indicate
> 'sort_order', not '_sortOrder'.
> - AFAICT, the two instances where Sort (false) occurs are immediately
> followed by a call to Redraw.  So other than the overloading conflict
> issue is there a reason for the redraw parameter on that new Sort
> overload?

One more comment.  Can you add some unit tests to verify selection
handling during sorted adds, inserts, and removes?

-- 
Mike Kestner  <mkestner at novell.com>
SUSE® Linux Enterprise 10
Your Linux is ready™
www.novell.com/linux