[Mono-list] Some more class library compliance issues

[Piers Haken]

I'm updating corcompare to report incorrect return types. Eventually
these will show up flagged as errors in the class-status pages, but for
now I thought I'd post them here.

Does it really matter that, for example, ArrayList.FixedSize() returns
ArrayList and not Ilist (since ArrayList is derived from Ilist)? Code
that compiles with CSC should compile on MCS, but not necessarily
visa-versa.

If you see any false negatives, please let me know.

Piers.


-- corlib.dll --
WARNING:
System.Collections.ArrayList.FixedSize(System.Collections.IList) returns
incorrect type: 'System.Collections.ArrayList' [should be:
'System.Collections.IList']
WARNING:
System.Collections.ArrayList.Synchronized(System.Collections.IList)
returns incorrect type: 'System.Collections.ArrayList' [should be:
'System.Collections.IList']
WARNING: System.Collections.ArrayList.ReadOnly(System.Collections.IList)
returns incorrect type: 'System.Collections.ArrayList' [should be:
'System.Collections.IList']
WARNING:
System.Runtime.Serialization.IFormatter.Serialize(System.IO.Stream,
System.Object) returns incorrect type: 'System.Object' [should be:
'Void']
WARNING: System.ObsoleteAttribute.Message is: 'Field' [should be:
'Property']
WARNING: System.ObsoleteAttribute.IsError is: 'Field' [should be:
'Property']

-- System.dll --
WARNING: System.Uri.get_Port() returns incorrect type: 'System.String'
[should be: 'Int32']
WARNING: System.CodeDom.CodeArrayCreateExpression.get_CreateType()
returns incorrect type: 'System.String' [should be:
'System.CodeDom.CodeTypeReference']
WARNING: System.CodeDom.CodeAttributeArgumentCollection.get_Item(Int32)
returns incorrect type: 'System.Object' [should be:
'System.CodeDom.CodeAttributeArgument']
WARNING:
System.CodeDom.CodeAttributeArgumentCollection.Add(System.CodeDom.CodeAt
tributeArgument) returns incorrect type: 'Void' [should be: 'Int32']
WARNING:
System.CodeDom.CodeAttributeDeclarationCollection.get_Item(Int32)
returns incorrect type: 'System.Object' [should be:
'System.CodeDom.CodeAttributeDeclaration']
WARNING:
System.CodeDom.CodeAttributeDeclarationCollection.Add(System.CodeDom.Cod
eAttributeDeclaration) returns incorrect type: 'Void' [should be:
'Int32']
WARNING: System.CodeDom.CodeBinaryOperatorExpression.get_Operator()
returns incorrect type: 'CodeBinaryOperatorType' [should be:
'System.CodeDom.CodeBinaryOperatorType']
WARNING: System.CodeDom.CodeCastExpression.get_TargetType() returns
incorrect type: 'System.String' [should be:
'System.CodeDom.CodeTypeReference']
WARNING: System.CodeDom.CodeCatchClauseCollection.get_Item(Int32)
returns incorrect type: 'System.Object' [should be:
'System.CodeDom.CodeCatchClause']
WARNING:
System.CodeDom.CodeCatchClauseCollection.Add(System.CodeDom.CodeCatchCla
use) returns incorrect type: 'Void' [should be: 'Int32']
WARNING: System.CodeDom.CodeMemberMethod.get_ReturnType() returns
incorrect type: 'System.String' [should be:
'System.CodeDom.CodeTypeReference']
WARNING: System.CodeDom.CodeDelegateCreateExpression.get_DelegateType()
returns incorrect type: 'System.String' [should be:
'System.CodeDom.CodeTypeReference']
WARNING: System.CodeDom.CodeExpressionCollection.get_Item(Int32) returns
incorrect type: 'System.Object' [should be:
'System.CodeDom.CodeExpression']
WARNING:
System.CodeDom.CodeExpressionCollection.Add(System.CodeDom.CodeExpressio
n) returns incorrect type: 'Void' [should be: 'Int32']
WARNING: System.CodeDom.CodeMemberEvent.get_Type() returns incorrect
type: 'System.String' [should be: 'System.CodeDom.CodeTypeReference']
WARNING: System.CodeDom.CodeMemberField.get_Type() returns incorrect
type: 'System.String' [should be: 'System.CodeDom.CodeTypeReference']
WARNING: System.CodeDom.CodeMemberProperty.get_Type() returns incorrect
type: 'System.String' [should be: 'System.CodeDom.CodeTypeReference']
WARNING: System.CodeDom.CodeNamespaceImportCollection.get_Item(Int32)
returns incorrect type: 'System.Object' [should be:
'System.CodeDom.CodeNamespaceImport']
WARNING: System.CodeDom.CodeObjectCreateExpression.get_CreateType()
returns incorrect type: 'System.String' [should be:
'System.CodeDom.CodeTypeReference']
WARNING:
System.CodeDom.CodeParameterDeclarationExpression.get_CustomAttributes()
returns incorrect type: 'System.CodeDom.CodeAttributeBlock' [should be:
'System.CodeDom.CodeAttributeDeclarationCollection']
WARNING: System.CodeDom.CodeParameterDeclarationExpression.get_Type()
returns incorrect type: 'System.String' [should be:
'System.CodeDom.CodeTypeReference']
WARNING:
System.CodeDom.CodeParameterDeclarationExpressionCollection.get_Item(Int
32) returns incorrect type: 'System.Object' [should be:
'System.CodeDom.CodeParameterDeclarationExpression']
WARNING:
System.CodeDom.CodeParameterDeclarationExpressionCollection.Add(System.C
odeDom.CodeParameterDeclarationExpression) returns incorrect type:
'Void' [should be: 'Int32']
WARNING: System.CodeDom.CodeStatementCollection.get_Item(Int32) returns
incorrect type: 'System.Object' [should be:
'System.CodeDom.CodeStatement']
WARNING:
System.CodeDom.CodeStatementCollection.Add(System.CodeDom.CodeStatement)
returns incorrect type: 'Void' [should be: 'Int32']
WARNING: System.CodeDom.CodeTypeOfExpression.get_Type() returns
incorrect type: 'System.String' [should be:
'System.CodeDom.CodeTypeReference']
WARNING: System.CodeDom.CodeTypeReferenceExpression.get_Type() returns
incorrect type: 'System.String' [should be:
'System.CodeDom.CodeTypeReference']
WARNING: System.CodeDom.CodeVariableDeclarationStatement.get_Type()
returns incorrect type: 'System.String' [should be:
'System.CodeDom.CodeTypeReference']
WARNING: System.ComponentModel.Component.Disposed is: 'Field' [should
be: 'Event']
WARNING: System.Diagnostics.TraceListenerCollection.get_Item(Int32)
returns incorrect type: 'System.Object' [should be:
'System.Diagnostics.TraceListener']

-- System.Xml.dll --
WARNING: System.Xml.XmlDocument.NodeInserting is: 'Field' [should be:
'Event']
WARNING: System.Xml.XmlDocument.NodeInserted is: 'Field' [should be:
'Event']
WARNING: System.Xml.XmlDocument.NodeRemoving is: 'Field' [should be:
'Event']
WARNING: System.Xml.XmlDocument.NodeRemoved is: 'Field' [should be:
'Event']
WARNING: System.Xml.XmlDocument.NodeChanging is: 'Field' [should be:
'Event']
WARNING: System.Xml.XmlDocument.NodeChanged is: 'Field' [should be:
'Event']
WARNING: System.Xml.XmlElement.SetAttribute(System.String,
System.String, System.String) returns incorrect type: 'Void' [should be:
'System.String']
WARNING: System.Xml.XPath.XPathNavigator.MoveToRoot() returns incorrect
type: 'Boolean' [should be: 'Void']

-- System.Web.dll --
WARNING: System.Web.Caching.Cache.get_Count() returns incorrct type:
'Int64' [should be: 'Int32']