[Mono-list] Re: Patch for MSG_NOSIGNAL

Dick Porter dick@ximian.com
Wed, 12 Jun 2002 20:00:05 +0100


On Wed, Jun 12, 2002 at 07:38:53PM +0200, Jaroslaw Kowalski wrote:
> 
> Thanks.
> 
> I'm not sure if the functions marked as "(called by the daemon)" in
> daemon-messages.c should really call signal() before and after each call.
> This is desired in library code (as you don't want global signal handler
> installed) but I think that daemon would benefit from moving signal()
> call out of the inner loop, where at the very beginning you'd install
> SIGPIPE handler and forget using MSG_NOSIGNAL in daemon functions.
> 
> This would result in much cleaner code.
> What do you think?

Good thinking.

- Dick