[Mono-list] Re: Patch for MSG_NOSIGNAL
Thu, 13 Jun 2002 09:14:18 +0200 (CEST)
I've noticed you are still testing for the presence of MSG_NOSIGNAL in
daemon.c. Why? You can just install the handler and forget MSG_NOSIGNAL
and all #ifdef's in _wapi_daemon_* code...
On Wed, 12 Jun 2002, Dick Porter wrote:
> On Wed, Jun 12, 2002 at 07:38:53PM +0200, Jaroslaw Kowalski wrote:
> > Thanks.
> > I'm not sure if the functions marked as "(called by the daemon)" in
> > daemon-messages.c should really call signal() before and after each call.
> > This is desired in library code (as you don't want global signal handler
> > installed) but I think that daemon would benefit from moving signal()
> > call out of the inner loop, where at the very beginning you'd install
> > SIGPIPE handler and forget using MSG_NOSIGNAL in daemon functions.
> > This would result in much cleaner code.
> > What do you think?
> Good thinking.
> - Dick
> Mono-list maillist - Monofirstname.lastname@example.org