[Mono-list] Re: Patch for MSG_NOSIGNAL

Jaroslaw Kowalski jarek@atm.com.pl
Wed, 12 Jun 2002 19:38:53 +0200 (CEST)


I'm not sure if the functions marked as "(called by the daemon)" in
daemon-messages.c should really call signal() before and after each call.
This is desired in library code (as you don't want global signal handler
installed) but I think that daemon would benefit from moving signal()
call out of the inner loop, where at the very beginning you'd install
SIGPIPE handler and forget using MSG_NOSIGNAL in daemon functions.

This would result in much cleaner code.
What do you think?


On Wed, 12 Jun 2002, Dick Porter wrote:

> On Mon, Jun 10, 2002 at 08:19:06PM +0200, Jaroslaw Kowalski wrote:
> > Hi all!
> > 
> > I've prepared a patch that prevents SIGPIPE from being raised while
> > reading/writing from/to a closed socket. It uses MSG_NOSIGNAL technique that
> > has been discussed some time ago.
> > 
> > Can you please verify it and commit to CVS?
> Committed (I made the same change to daemon-messages.c too)
> - Dick
> _______________________________________________
> Mono-list maillist  -  Mono-list@ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-list