[Mono-dev] [PATCH] Use recursive AscW in VB runtime (2)

[Rafael Mizrahi]

Kornél,
I have tested and I agree with your patch. 
Sorry for the extra iteration.

Please commit,
Rafael

-----Original Message-----
From: mono-devel-list-bounces at lists.ximian.com [mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf Of Rafael Mizrahi
Sent: Tuesday, September 12, 2006 12:38
To: mono-devel-list at lists.ximian.com
Subject: Re: [Mono-dev] [PATCH] Use recursive AscW in VB runtime (2)

Kornél,

I don't understand your patch, you are calling AscW within AscW function.
Isn't it will generate a StackOverflow exception ?

         Public Function AscW(ByVal c As Char) As Integer
-            Return Convert.ToInt32(c)
+            ' Compiled as if it were "Return CInt(c)" when /novbruntimeref is used
+            Return AscW(c)
         End Function

Rafael

-----Original Message-----
From: mono-devel-list-bounces at lists.ximian.com [mailto:mono-devel-list-bounces at lists.ximian.com] On Behalf Of Kornél Pál
Sent: Tuesday, September 12, 2006 12:17
To: mono-devel-list at lists.ximian.com
Subject: [Mono-dev] [PATCH] Use recursive AscW in VB runtime (2)

Hi,

/novbruntimeref treats AscW specially as it is compiled as if it were CInt
(no AscW method is called).

Now vbnc has support for this as well and a dedicated test case ensures this 
behavior.

Please review and approve the patch.

Kornél 
_______________________________________________
Mono-devel-list mailing list
Mono-devel-list at lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-devel-list