[Mono-devel-list] Re: [Mono-patches] r43792 - in trunk/mcs/build: . profiles

[Miguel de Icaza]

Hello,

> > > 	* profiles/basic.make: The test for mcs was broken on jails where
> > > 	we got a warning due to /proc not being mounted. Remove hackish wc
> > > 	usage.
> > 
> > ???  Why remove a working test that caught an actual problem?
> > 
> > What's wrong with adding a 'mount /proc' to the jail setup script?  We
> > are not worried about running untrusted code inside the jail.
> 
> Because anything could create extra text. Say I wanted to run make with
> MONO_LOG_LEVEl set? Maybe I am running with some light weight profiler?

I agree with Raja that we should not remove tests that actually flag a
problem.   Lets discuss in the office.

Mounting /proc is something that is needed for the jails anyways.

> My test made sure the exit status of mono was correct (at least, I am
> pretty sure it does) -- this is what really matters. If mcs can run and
> create a binary that returns a 0 exit status, things are probably
> working OK.