[Mono-devel-list] Re: [Mono-patches] r43792 - in trunk/mcs/build: . profiles

[Ben Maurer]

Hey,

On Mon, 2005-05-02 at 12:17 +0530, Raja R Harinath wrote:
> "Ben Maurer <benm at mono-cvs.ximian.com>" <benm at mono-cvs.ximian.com> writes:
> 
> > 2005-04-29  Ben Maurer  <bmaurer at ximian.com>
> >
> > 	* profiles/basic.make: The test for mcs was broken on jails where
> > 	we got a warning due to /proc not being mounted. Remove hackish wc
> > 	usage.
> 
> ???  Why remove a working test that caught an actual problem?
> 
> What's wrong with adding a 'mount /proc' to the jail setup script?  We
> are not worried about running untrusted code inside the jail.

Because anything could create extra text. Say I wanted to run make with
MONO_LOG_LEVEl set? Maybe I am running with some light weight profiler?

My test made sure the exit status of mono was correct (at least, I am
pretty sure it does) -- this is what really matters. If mcs can run and
create a binary that returns a 0 exit status, things are probably
working OK.

> Also, something inside mono seems to like having /proc mounted -- that's
> why the warning.  So, why not fix that instead?

I want to keep the rpm build scripts simple. If I keep on adding hack
after hack, the scripts are going to become a mess. Its much cleaner to
make the build system a bit more flexible so that it does not need
customization on the user's part to build.

-- Ben