[Mono-devel-list] Re: [Mono-patches] r43792 - in trunk/mcs/build: . profiles

[Ben Maurer]

I talked about this with Miguel today, but for the record:

On Tue, 2005-05-03 at 11:20 -0400, Miguel de Icaza wrote:
> > > > 	* profiles/basic.make: The test for mcs was broken on jails where
> > > > 	we got a warning due to /proc not being mounted. Remove hackish wc
> > > > 	usage.
> > > 
> > > ???  Why remove a working test that caught an actual problem?
> > > 
> > > What's wrong with adding a 'mount /proc' to the jail setup script?  We
> > > are not worried about running untrusted code inside the jail.
> > 
> > Because anything could create extra text. Say I wanted to run make with
> > MONO_LOG_LEVEl set? Maybe I am running with some light weight profiler?
> 
> I agree with Raja that we should not remove tests that actually flag a
> problem.   Lets discuss in the office.

Miguel is OK with relying just on a test of the exit value, and not on
the wc -l on the file.

> Mounting /proc is something that is needed for the jails anyways.

Miguel convinced me that this is true. Ironically, Paolo's commit
(r43924) now requires /proc to be mounted -- otherwise things will error
out hard.

-- Ben