[Mono-devel-list] Patch for DirectoryServices.DirectoryEntry

[Raja R Harinath]

Hi,

Boris Kirzner <borisk at mainsoft.com> writes:

> DirectoryEntry.cs :
> - Implemented UsePropertyCache.
> - Refresh entry after Rename and MoveTo.
> - CommitChanges : do not send request to server if no properties
> changed. Drop new flag after committing newly created entry.
> - Disconnect only if connected in Close(). Clean up Dispose().
> - Removed unnecessary console output.
> PropertyCollection.cs : Hold reference to parent DirectoryEntry.
> PropertyValueCollection.cs : Hold reference to parent
> DirectoryEntry. Call parent's CommitDeferred on collection changes.
>
> If no one objects, I'll commit
[snip]
> Index: PropertyValueCollection.cs
> ===================================================================
> --- PropertyValueCollection.cs	(revision 41947)
> +++ PropertyValueCollection.cs	(working copy)
[snip]
> @@ -136,21 +138,33 @@
>  		[MonoTODO]
>  		protected override void OnClearComplete ()
>  		{
> +			if (_parent != null) {
> +				_parent.CommitDeferred();
> +			}
>  		}
>  
>  		[MonoTODO]
>  		protected override void OnInsertComplete (int index, object value)
>  		{
> +			if (_parent != null) {
> +				_parent.CommitDeferred();
> +			}
>  		}
[snip similar]

If this implements the desired functionality, I think you can remove the
MonoTODO attribute there.

> Index: DirectoryEntry.cs
> ===================================================================
> --- DirectoryEntry.cs	(revision 41947)
> +++ DirectoryEntry.cs	(working copy)
[snip]
>  			[MonoTODO]
>  			get 
>  			{
> -				throw new NotImplementedException();
> +				return _usePropertyCache;
>  			}
>  			[MonoTODO]
>  			set 
>  			{
> -				throw new NotImplementedException();
> +				_usePropertyCache = value;
>  			}
>  		}

Likewise.

Thanks,
- Hari