[Mono-devel-list] Patch for full-featured mcs /doc support

Atsushi Eno atsushi at ximian.com
Wed Nov 24 10:33:25 EST 2004


Hello,

>>-MCS = MONO_PATH="$(topdir)/class/lib/$(PROFILE)$(PLATFORM_PATH_SEPARATOR)$$MONO_PATH" $(INTERNAL_MCS)
>>+MCS = MONO_PATH="$(topdir)/class/lib/$(PROFILE) $(PLATFORM_PATH_SEPARATOR) $$MONO_PATH" $(INTERNAL_MCS)
>> endif
> 
> 
> This probably is an oversight.  Remove this hunk.

Oops.

>>-run-test-local: multi test-harness test-casts
>>+run-test-local: multi test-harness test-casts xmldocdiff.exe xml-doc

> Don't mention xmldocdiff.exe here.

Okay.

>>+xml-doc:
>>+	@$(MAKE) -s xml-doc-run
>>+
>>+xml-doc-tests := $(filter xml-%, $(TEST_SOURCES))
>>+
>>+xml-doc-run:
>>+	@echo "Testing /doc outputs..."
>>+	@test -z "$(xml-doc-tests)" || for i in ''$(xml-doc-tests); do $(TEST_RUNTIME) xmldocdiff.exe $$i-ref.xml dir-$(TEST_TAG)/$$i.xml; done
> 
> 
> Unify xml-doc and xml-doc-run, and make xml-doc depend on xmldocdiff.exe
> and test-harness.  
> 
> I think you should put in some more code to collect the results,
> summarize them, create a logfile, etc.

Ok, so maybe I had better put them into harness.mk and
add more conditions for .xml files like .exe and .dll.

Thanks,
Atsushi Eno



More information about the Mono-devel-list mailing list