[Mono-devel-list] Patch for full-featured mcs /doc support

Raja R Harinath rharinath at novell.com
Thu Nov 25 01:18:10 EST 2004


Hi,

Atsushi Eno <atsushi at ximian.com> writes:

>>>+xml-doc:
>>>+	@$(MAKE) -s xml-doc-run
>>>+
>>>+xml-doc-tests := $(filter xml-%, $(TEST_SOURCES))
>>>+
>>>+xml-doc-run:
>>>+	@echo "Testing /doc outputs..."
>>>+	@test -z "$(xml-doc-tests)" || for i in ''$(xml-doc-tests); do $(TEST_RUNTIME) xmldocdiff.exe $$i-ref.xml dir-$(TEST_TAG)/$$i.xml; done
>> Unify xml-doc and xml-doc-run, and make xml-doc depend on
>> xmldocdiff.exe
>> and test-harness.  I think you should put in some more code to collect
>> the results,
>> summarize them, create a logfile, etc.
>
> Ok, so maybe I had better put them into harness.mk and
> add more conditions for .xml files like .exe and .dll.

You probably just need to replace the current 

  echo "PASS: $*" > $@ ; \
  rm -f $$testlogfile ; \

with

  if test -f $*.xml then \
    if $(XMLDOCDIFF) ../$*-ref.xml $*.xml >> $$testlogfile; then \
      echo "PASS: $*" > $@ ; \
      rm -f $*.xml $$testlogfile ; \
    else
      echo "FAIL: $*: xml comparison" > $@ ; \
  else \
    echo "PASS: $*" > $@ ; \
    rm -f $$testlogfile ; \
  fi

- Hari



More information about the Mono-devel-list mailing list