[Mono-devel-list] Patch for full-featured mcs /doc support

[Raja R Harinath]

Hi,

Atsushi Eno <atsushi at ximian.com> writes:

[snip]
> Would you please review this new patch?

I've only looked at the Makefile portion.

> -MCS = MONO_PATH="$(topdir)/class/lib/$(PROFILE)$(PLATFORM_PATH_SEPARATOR)$$MONO_PATH" $(INTERNAL_MCS)
> +MCS = MONO_PATH="$(topdir)/class/lib/$(PROFILE) $(PLATFORM_PATH_SEPARATOR) $$MONO_PATH" $(INTERNAL_MCS)
>  endif

This probably is an oversight.  Remove this hunk.

> @@ -155,7 +156,7 @@
>  
>  test-local: 
>  
> -run-test-local: multi test-harness test-casts
> +run-test-local: multi test-harness test-casts xmldocdiff.exe xml-doc

Don't mention xmldocdiff.exe here.
  
> +xml-doc:
> +	@$(MAKE) -s xml-doc-run
> +
> +xml-doc-tests := $(filter xml-%, $(TEST_SOURCES))
> +
> +xml-doc-run:
> +	@echo "Testing /doc outputs..."
> +	@test -z "$(xml-doc-tests)" || for i in ''$(xml-doc-tests); do $(TEST_RUNTIME) xmldocdiff.exe $$i-ref.xml dir-$(TEST_TAG)/$$i.xml; done

Unify xml-doc and xml-doc-run, and make xml-doc depend on xmldocdiff.exe
and test-harness.  

I think you should put in some more code to collect the results,
summarize them, create a logfile, etc.

Otherwise, looks ok.

- Hari