[MonoDevelop] Patch allowing support for MonoXNA addin

Lluis Sanchez Gual slluis.devel at gmail.com
Mon Mar 15 12:34:06 EDT 2010


The patch is now in SVN, with a small change in MSBuildFileFormat.
GetValidFormatName can be called when there is still to item handler for
the project, and this was causing some failures in the unit tests. I
added a GetItemExtension method that does the same but which doesn't
need to get the item handler.

Thanks,
Lluis.

El dt 09 de 03 de 2010 a les 20:13 +0100, en/na Lars Magnusson va
escriure:
> I did an update before writing the change logs. I suspect this changed
> the return type on MSBuildProjectService.GetItemHandler because I
> suddenly got a build error in MSBuildFileFormat.GetValidFormatName. I
> fixed it by doing an explicit cast the correct type, but I'm not sure
> if this is safe or not.
> 
> Anyway, I've attached the final patch in this post.
> 
> -lavima
> 
> On Tue, Mar 9, 2010 at 2:36 PM, Lluis Sanchez Gual
> <slluis.devel at gmail.com> wrote:
> > El dt 09 de 02 de 2010 a les 09:53 +0100, en/na Lars Magnusson va
> > escriure:
> >> I've implemented some changes that changes the behavior in the way you
> >> described. I'm not completely sure it is what you wanted though, so I
> >> would like to confirm that I'm on the right path before finishing up
> >> the update (haven't changed the changelog or done any proper testing)
> >>
> >> Looking forward to your feedback
> >
> > Yes, the patch looks good. My only comment is that LoadProjectTypeGuids
> > could be optimized a bit (there is no need to read the whole project to
> > get the guids), but it can be done later on, no big issue.
> >
> > Lluis.
> >
> >
> >




More information about the Monodevelop-list mailing list