[MonoDevelop] Patch allowing support for MonoXNA addin

Lars Magnusson lavima at gmail.com
Tue Mar 9 14:13:54 EST 2010


I did an update before writing the change logs. I suspect this changed
the return type on MSBuildProjectService.GetItemHandler because I
suddenly got a build error in MSBuildFileFormat.GetValidFormatName. I
fixed it by doing an explicit cast the correct type, but I'm not sure
if this is safe or not.

Anyway, I've attached the final patch in this post.

-lavima

On Tue, Mar 9, 2010 at 2:36 PM, Lluis Sanchez Gual
<slluis.devel at gmail.com> wrote:
> El dt 09 de 02 de 2010 a les 09:53 +0100, en/na Lars Magnusson va
> escriure:
>> I've implemented some changes that changes the behavior in the way you
>> described. I'm not completely sure it is what you wanted though, so I
>> would like to confirm that I'm on the right path before finishing up
>> the update (haven't changed the changelog or done any proper testing)
>>
>> Looking forward to your feedback
>
> Yes, the patch looks good. My only comment is that LoadProjectTypeGuids
> could be optimized a bit (there is no need to read the whole project to
> get the guids), but it can be done later on, no big issue.
>
> Lluis.
>
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MonoDevelop.Projects.patch
Type: text/x-patch
Size: 5800 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/monodevelop-list/attachments/20100309/0cc8fa90/attachment-0001.bin 


More information about the Monodevelop-list mailing list