[MonoDevelop] [PATCH] configure switch editor
Lluis Sanchez Gual
lluis at novell.com
Tue Jun 9 12:08:25 EDT 2009
The gui looks better, but it still needs some work.
* The buttons should be aligned with with the list (don't know why
they are indented).
* The dialog could include an explanation of what is it for and
what information has to be entered. It is not obvious looking at
* The window is not transient wrt the parent window, so it is not
focused when shown.
* When clicking on Add the focus should be moved to the newly
added row, so the user can start typing the new switch right
* Those NEW strings added to new rows are really ugly. I dont
think they are necessary if the above change is done.
El dv 05 de 06 de 2009 a les 18:00 +0200, en/na Jérémie Laval va
> Thanks for the review !
> Modified patch based on your comments attached.
> - Use homemade escaping for switch name (lower characters and -
> separator) and for define (upper characters and _ separator).
> - GUI fixes
> * Remove the entries
> * Editing is solely done with the treeview
> * Changed treeview columns name to respect HIG
> * Increase the dialog margin
> * Edit button now placed at the bottom of the notebook page
> Jérémie Laval
> jeremie.laval at gmail.com
> 2009/6/2 Lluis Sanchez Gual <lluis at novell.com>
> I like the idea. There are some issues with the GUI, you
> should take a
> look at the GNOME HIG. Some comments:
> * Labels should be aligned to the left.
> * There should be no spacing between the text of the
> label and the
> * The margin between the controls and the border of the
> window is
> too small.
> * The GUI is a bit confusing. There are entries for
> entering the
> data, which are updated when the selection changes in
> the list,
> but changing the entries won't update the list.
> modifications must be done directly in the list. It
> would be
> better to do all editing in the list.
> * Configuration switches should not be specific to
> Autotools. We
> could support them also with simple makefiles (although
> this can
> be done later).
> El dc 27 de 05 de 2009 a les 21:56 +0200, en/na Jérémie Laval
> > Hello folks,
> > This patch adds the necessary stuff and UI to allows user to
> > personal switch to their autotools deployment project (i.e.
> > like --enable-foo when running ./configure). It then allows
> to map
> > these configure switchs to specific define that the user can
> check in
> > their source code with #if ... #endif constructs.
> > At the moment, the UI is fairly basic. It just add a "Edit
> > switchs" button under the "Autotools" radio in the project
> > that then fire up a configuration dialog. Since I'm quite a
> > usability disaster I welcome any inputs for improvements.
> > Thanks in advance for reviewing.
> > PS: the patch don't yet include the ChangeLog entries, I
> will add them
> > when the code will be fine.
> > --
> > Jérémie Laval
> > jeremie.laval at gmail.com
> > http://garuma.wordpress.com
> > _______________________________________________
> > Monodevelop-list mailing list
> > Monodevelop-list at lists.ximian.com
> > http://lists.ximian.com/mailman/listinfo/monodevelop-list
> Monodevelop-list mailing list
> Monodevelop-list at lists.ximian.com
More information about the Monodevelop-list