[MonoDevelop] [PATCH] configure switch editor

[Jérémie Laval]

Thanks for the review !

Modified patch based on your comments attached.

ChangeLog:
- Use homemade escaping for switch name (lower characters and - separator)
and for define (upper characters and _ separator).
- GUI fixes
    * Remove the entries
    * Editing is solely done with the treeview
    * Changed treeview columns name to respect HIG
    * Increase the dialog margin
    * Edit button now placed at the bottom of the notebook page

--
Jérémie Laval
jeremie.laval at gmail.com
http://garuma.wordpress.com


2009/6/2 Lluis Sanchez Gual <lluis at novell.com>

> Hi,
>
> I like the idea. There are some issues with the GUI, you should take a
> look at the GNOME HIG. Some comments:
>
>      * Labels should be aligned to the left.
>      * There should be no spacing between the text of the label and the
>        colon.
>      * The margin between the controls and the border of the window is
>        too small.
>      * The GUI is a bit confusing. There are entries for entering the
>        data, which are updated when the selection changes in the list,
>        but changing the entries won't update the list. Instead,
>        modifications must be done directly in the list. It would be
>        better to do all editing in the list.
>      * Configuration switches should not be specific to Autotools. We
>        could support them also with simple makefiles (although this can
>        be done later).
>
> Lluis.
>
> El dc 27 de 05 de 2009 a les 21:56 +0200, en/na Jérémie Laval va
> escriure:
> > Hello folks,
> >
> > This patch adds the necessary stuff and UI to allows user to add
> > personal switch to their autotools deployment project (i.e. something
> > like --enable-foo when running ./configure). It then allows to map
> > these configure switchs to specific define that the user can check in
> > their source code with #if ... #endif constructs.
> >
> > At the moment, the UI is fairly basic. It just add a "Edit configure
> > switchs" button under the "Autotools" radio in the project preferences
> > that then fire up a configuration dialog. Since I'm quite a UI
> > usability disaster I welcome any inputs for improvements.
> >
> > Thanks in advance for reviewing.
> >
> > PS: the patch don't yet include the ChangeLog entries, I will add them
> > when the code will be fine.
> >
> > --
> > Jérémie Laval
> > jeremie.laval at gmail.com
> > http://garuma.wordpress.com
> > _______________________________________________
> > Monodevelop-list mailing list
> > Monodevelop-list at lists.ximian.com
> > http://lists.ximian.com/mailman/listinfo/monodevelop-list
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/monodevelop-list/attachments/20090605/23d79037/attachment-0001.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: switch.diff
Type: text/x-patch
Size: 40561 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/monodevelop-list/attachments/20090605/23d79037/attachment-0001.bin