[MonoDevelop] New Patch to MonoDevelop.WebReference Addin

[Michael Hutchinson]

On Tue, Dec 2, 2008 at 11:40 AM, Lluis Sanchez Gual <lluis at novell.com> wrote:
> Some comments:
>      * Use XmlElement.SetAttribute/GetAttribute to get/set attributes
>        to an element.
>      * Why are you using TextFile? you don't need it. You can directly
>        load the file into the XmlDocument.

IIRC I advised using TextFile, because it implements the
IEditableTextFile interface, which would make it easier to support
editing files that are open in MD (though that doesn't seem to be done
here). Also, it has safer write semantics.

AspNetAppProject.cs has an example of editing web.config like this.

>      * this is not correct, it should be a type reference:
>        new CodeVariableReferenceExpression ("System.Configuration.ConfigurationManager")
>      * In the ChangeLog entry, specify the files that have changed. See
>        how it is done in the previous entries.
>      * The web service url entry at the top of the "Add Web Reference"
>        dialog is not showing the url of the service.
>      * When adding a web reference to a project, why does the user have
>        to select a project for the app.config? it should be the same
>        project.
>      * The advanced section in the dialog has several issues:
>              * Labels should be aligned to the left and end with a
>                colon.
>              * I think the text of the checkbox is very confusing. I
>                would rather change it to "Read web service URL from
>                app.config"
>              * The project combo is not needed
>              * I would group Namespace, the checkbox and the key entry
>                in a "Web Service Proxy Options" section.
>
> Thanks!
> Lluis.
>
> El dc 26 de 11 de 2008 a les 01:49 +0000, en/na Luciano _ va escriure:
>> Lluis:
>>          Sorry for the *Long Delay" i was a busy with other stuff.
>>
>> I attach the new patch with your suggestion. Let me know if you find
>> something else.
>>
>> Thanks
>> Lucian0

-- 
Michael Hutchinson
http://mjhutchinson.com