[MonoDevelop] New Patch to MonoDevelop.WebReference Addin

[Lluis Sanchez Gual]

Some comments:
      * Use XmlElement.SetAttribute/GetAttribute to get/set attributes
        to an element.
      * Why are you using TextFile? you don't need it. You can directly
        load the file into the XmlDocument.
      * this is not correct, it should be a type reference:
        new CodeVariableReferenceExpression ("System.Configuration.ConfigurationManager")
      * In the ChangeLog entry, specify the files that have changed. See
        how it is done in the previous entries.
      * The web service url entry at the top of the "Add Web Reference"
        dialog is not showing the url of the service.
      * When adding a web reference to a project, why does the user have
        to select a project for the app.config? it should be the same
        project.
      * The advanced section in the dialog has several issues:
              * Labels should be aligned to the left and end with a
                colon.
              * I think the text of the checkbox is very confusing. I
                would rather change it to "Read web service URL from
                app.config"
              * The project combo is not needed
              * I would group Namespace, the checkbox and the key entry
                in a "Web Service Proxy Options" section. 

Thanks!
Lluis.

El dc 26 de 11 de 2008 a les 01:49 +0000, en/na Luciano _ va escriure:
> Lluis:
>          Sorry for the *Long Delay" i was a busy with other stuff.
> 
> I attach the new patch with your suggestion. Let me know if you find
> something else.
> 
> Thanks
> Lucian0
> 
> 
> 
> > Subject: Re: [MonoDevelop] New Patch to MonoDevelop.WebReference
> Addin
> > From: lluis at novell.com
> > To: lnc19 at hotmail.com
> > CC: monodevelop-list at lists.ximian.com
> > Date: Mon, 3 Nov 2008 18:10:50 -0500
> > 
> > Hi,
> > 
> > Thanks for the patch. Here are some comments:
> > 
> > * In AddUrlToConfiguration, please use SelectSingleNode to look
> > for an existing url property. It will simplify the code.
> > * Don't generate C# specific code with CodeSnippetStatement.
> > * Remove the debug Console.WriteLine you introduced.
> > * Messages such as "¿Are you sure you want to delete Web
> > Reference?" should be queried using GettextCatalog, so they can
> > be properly translated. Also, remove the ¿.
> > * The same for calls to StatusBar.ShowMessage
> > * Modify the window using the Designer. If it doesn't work for
> > you, please update to latest MD. 
> > 
> > Lluis.
> > 
> > El dl 03 de 11 de 2008 a les 00:29 +0000, en/na Luciano _ va
> escriure:
> > > Hi:
> > > I attach 2 files:
> > > 
> > > 1) A screenshot of a new future (MonoDevelop.WebReference).
> > > 2) The patch.
> > > 
> > > Explanation has two parts:
> > > 
> > > 1) A minor "change" to delete command: Confirm Dialog when
> deleting a WebReference and the same for the "Delete All Reference".
> > > 
> > > 2) The second part, and bigger, is a Future: with this patch
> WebReference let you select a Project to store the URL in the project
> app.config file. If the file (app.config) doesn't exists, it is
> created automatically with this key, if exists, and you have more keys
> in this file, it let you select one previous added key or add new one.
> If you update a WebReference that has a "Key" in the app.config file
> assigned and proxy was generated against this key, it re-creates the
> proxy class with this configuration reference.
> > > I did this configuration per-project and not for the selected
> project beacause some times you've a project which is a library and
> you don't want to store the URL in this app.Config file, beacause is
> not the right one, you want to store it in the main Exe file or some
> other project. If you select a config key, the proxy class gets a new
> Constructor like:
> > > 
> > > public MyWebServices (bool useConfig)
> > > {
> > > ...Config Managment here...
> > > }
> > > 
> > > If you don't use this future, the web reference Url works like
> before.
> > > 
> > > Please, someone could review/commit it ?
> > > 
> > > Lucian0
> > > 
> > > 
> > > 
> > > _________________________________________________________________
> > > Reveal your inner athlete and share it with friends on Windows
> Live.
> > >
> http://revealyourinnerathlete.windowslive.com?locale=en-us&ocid=TXT_TAGLM_WLYIA_whichathlete_us
> > > _______________________________________________ Monodevelop-list
> mailing list Monodevelop-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/monodevelop-list
> > 
> 
> 
> ______________________________________________________________________
> Windows Live Hotmail now works up to 70% faster. Sign up today.