[MonoDevelop] text editor patch for simple class/member selector

["Andrés G. Aragoneses [ knocte ]]

atsushi eno escribió:
> Thanks for the hints Lluis :) With icons and ambience, it became much
> nicer than before.
> 
>>> - Is there already a way to get localized string for ClassType (such
>>>   as "class" and "struct") ? I believe yes but don't know where.
>> Nope, AFAIK.
> 
> Ok, now that types are accompanied by icons, there is no need to label
> types with text anymore.
> 
>> What I miss in this patch is a class selector, since there can be more
>> than one class in the same file. It would be also very useful to always
>> show in the combo the member where the cursor is positioned. AFAIR
>> somebody provided such a patch, but I don't remember what happened to
>> it.
> 
> In fact my first patch (only put on #monodevelop) contains two
> comboboxes, like what you have in mind and VS.NET has in reality.
> After short discussion with Miguel, I changed it to single combobox
> to use space more efficiently (as the new sshot shows, the formatted
> members, especially methods, are likely to be quite wide). But it is
> easy to switch back to the original two comboboxes, so I'd follow
> your decision.
> 
> I have some more questions:
> 
> 	- Does Ambience always exist? My patch premises its existence.
> 	- I don't feel comfortable to use FocusChildSet for the ComboBox
> 	  to detect control activation. Looks like it is invoked more
> 	  than I want. Is there better signal to use? I have to say,
> 	  I'm quite newbie in gtk land :|
> 
> New patch is attached, and new sshot is uploaded (it has only one
> combobox for now):
> http://monkey.workarea.jp/tmp/2007/add-class-member-shortcut-2.png
> 


Hey atsushi, this is a great feature! Just my two cents:

- Why not get the best of both worlds? If there is more than one class 
in the file, show two comboboxes, but if not, show one.

And I would go for hiding some information so as to avoid large combobox 
entries. For example I would hide keywords, pre-namespaces and type 
returned. Then, instead of:

virtual MonoDevelop.Ide.Gui.IViewContent CreateContentForMimeType(string 
  mimeType, System.IO.Stream content)

Just:

CreateContentForMimeType(strint mimeType, Stream content)


This way, it would be easier to look for the method we want and localize 
it by alphabetical order.

Regards,

	Andrés	[ knocte ]

--