[Monodevelop-devel] Language specific expression evaluator support
Lluis Sanchez Gual
slluis.devel at gmail.com
Fri Apr 23 05:37:53 EDT 2010
Feel free to commit. Thanks!
El dv 23 de 04 de 2010 a les 09:27 +0200, en/na Carlo Kok va escriure:
> On 4/22/2010 6:16 PM, Lluis Sanchez Gual wrote:
> > Hi,
> >
> > Thanks for the patch. It looks good in general, although I have some
> > comments:
> >
> > * Indenting seems to be done with spaces, it should be with tabs.
> > * Instead of having two handlers in DebuggerSession
> > (GetExpressionEvaluator and GetAllLocalsHandler), it would be
> > simpler to just have a single method which returns a
> > IExpressionEvaluator.
> > * The evaluators list in DebuggingService should be reset if there
> > is any change in the evaluators extension point (like what is
> > done for DebuggerEngines).
> >
>
> All fixed. New patch attached.
>
> --
> Carlo Kok
More information about the Monodevelop-devel-list
mailing list