[Monodevelop-devel] Language specific expression evaluator support

Carlo Kok ck at carlo-kok.com
Fri Apr 23 03:27:40 EDT 2010

On 4/22/2010 6:16 PM, Lluis Sanchez Gual wrote:
> Hi,
> Thanks for the patch. It looks good in general, although I have some
> comments:
>        * Indenting seems to be done with spaces, it should be with tabs.
>        * Instead of having two handlers in DebuggerSession
>          (GetExpressionEvaluator and GetAllLocalsHandler), it would be
>          simpler to just have a single method which returns a
>          IExpressionEvaluator.
>        * The evaluators list in DebuggingService should be reset if there
>          is any change in the evaluators extension point (like what is
>          done for DebuggerEngines).

All fixed. New patch attached.

Carlo Kok
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: custom_expression_evaluator5.patch
Url: http://lists.ximian.com/pipermail/monodevelop-devel-list/attachments/20100423/ea5226eb/attachment-0001.pl 

More information about the Monodevelop-devel-list mailing list