[Mono-winforms-list] [PATCH] Patch forSystem.Windows.Forms.Application to match MSDN specificationsfor Application Data

[Justin Cherniak]

Gert,

Seemingly this passed under my radar and I forgot to submit my changes.
Attached is the updated patch with the modified test cases.  If there is any
way this could be committed to 1.9 (since in some cases its a showstopper
bug), it would be much appreciated.

Thanks,
Justin Cherniak


On Nov 3, 2007 8:22 PM, Gert Driesen <gert.driesen at telenet.be> wrote:

>  Justin,
>
> A few "small" remarks:
>
> 1) Your test should first verify that these directories do not exist
> before the test is run, or perhaps remove them if they do exist.
> 2) Your should add a TearDown in which you remove the directories that
> were created by the unit test.
> 3) Use tabs instead of spaces.
> 4) It would also be nice if you could add tests that verify whether the
> registry keys are in fact created (same principle here, ensure they do not
> exist before your run the test to avoid false positives).
>
> I'd be happy to take care of these if you want.
>
> Gert
>
>  ------------------------------
> *From:* mono-winforms-list-bounces at lists.ximian.com [mailto:
> mono-winforms-list-bounces at lists.ximian.com] *On Behalf Of *Justin
> Cherniak
> *Sent:* zaterdag 3 november 2007 22:17
> *To:* mono-winforms-list at lists.ximian.com
> *Subject:* Re: [Mono-winforms-list] [PATCH] Patch
> forSystem.Windows.Forms.Application to match MSDN specificationsfor
> Application Data
>
> OK, Attached is the updates patch with new tests and ChangeLog entries.
> Can I commit?
>
> Thanks,
> Justin
>
> On Oct 31, 2007 9:33 AM, Andreia Gaita < shana.ufie at gmail.com> wrote:
>
> > On 10/31/07, Justin Cherniak < justin.cherniak at gmail.com> wrote:
> > > Let me ask, is there any documentation on writing tests, I'm a little
> > > unclear on how/where to do this?
> >
> > Take a look at the Managed.Windows.Forms/Test/System.Windows.Forms
> > directory, it has all the unit tests for mwf.  You basically set
> > properties and Assert() them, look at ButtonTest, for instance, to see
> > extensive property testing. ApplicationTest has the Application type
> > tests, so your tests should go in there. Just create a new public void
> > Method() marked with [Test], and add your tests. You can then run them
> > with make run-test on MWF.
> >
> > andreia gaita
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-winforms-list/attachments/20080213/6ffaba89/attachment-0001.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ApplicationData.patch
Type: application/octet-stream
Size: 6776 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-winforms-list/attachments/20080213/6ffaba89/attachment-0001.obj