[Mono-osx] [MonoMac] Adding WebKit DOM interfaces

[Alexander Shulgin]

On 27.10.2010 19:11, Geoff Norton wrote:
> Hello,
>
>    This generally looks great, but a few comments:
>
> - [BaseType (typeof (DomObject), Name="DOMRange")]
> + [BaseType (typeof (DomObject))]
>
>
> These types of changes (and the omission of Name) is wrong.  ObjC class
> names are case sensitive, but the .NET framework design guidelines
> disagree, so we use the Name parameter to map a .NET name to the real ObjC
> name.

Oh, now I got it.  I didn't fully understand why it was there and 
related it to DOM-classes being empty as opposed to Web*-ones further 
down in the file.  Will fix.

> -
> - [BaseType (typeof (DomObject), Name="DOMNode")]
> +
> + [BaseType (typeof (DomObject))]
>
>
> You should generally try to avoid whitespace changes.
>
> +  [Export ("item:")]
> +  DomNode Item (uint index);
>
>
> This should probably be called GetItem, and wrapped with a manual binding
> into a indexer.
>
> At a higher level, several of these objects appear to be good candidates
> for .NETizing  further, ie, DomNode could expose the children in an
> enumerator, etc.

Nice idea.  I'm going to ask for details when I come to this part.

> As for updating the monomac inside monodevelop, what you did should work,
> but ensure you close MonoDevelop before replacing the dll.

Sure I did close it.  There's also MonoDevelop.MonoMac.dll and 
MonoDevelop.Debugger.Soft.MonoMac.dll in the same folder.  May be I 
should update them to?  Anyone knows how to do that?

--
Alex