[Mono-osx] [MonoMac] Adding WebKit DOM interfaces

Geoff Norton gnorton at novell.com
Wed Oct 27 12:11:12 EDT 2010


Hello,

  This generally looks great, but a few comments:

- [BaseType (typeof (DomObject), Name="DOMRange")]
+ [BaseType (typeof (DomObject))]


These types of changes (and the omission of Name) is wrong.  ObjC class
names are case sensitive, but the .NET framework design guidelines
disagree, so we use the Name parameter to map a .NET name to the real ObjC
name.

- 
- [BaseType (typeof (DomObject), Name="DOMNode")]
+
+ [BaseType (typeof (DomObject))]


You should generally try to avoid whitespace changes.

+  [Export ("item:")]
+  DomNode Item (uint index);


This should probably be called GetItem, and wrapped with a manual binding
into a indexer.

At a higher level, several of these objects appear to be good candidates
for .NETizing  further, ie, DomNode could expose the children in an
enumerator, etc.

As for updating the monomac inside monodevelop, what you did should work,
but ensure you close MonoDevelop before replacing the dll.

-g

On 10-10-27 12:05 PM, "Alexander Shulgin"
<alexander.shulgin at yessoftware.com> wrote:

>Hello there,
>
>I'm trying to add some DOM interfaces to MonoMac's WebKit binding.
>
>Could someone please check out the attached patch and tell me if it's
>any good?  If so I'll proceed adding the rest of DOM interfaces and will
>send the whole patchset.
>
>Also, I'd like to say thank you for latest versions of MonoDevelop, it's
>going to rock! :)
>
>While we're at it, how should I proceed to try my updated version of
>monomac with my MonoDevelop.app from nightly builds?
>
>If I try to simply replace the AddIns/MonoDevelop.MonoMac/MonoMac.dll*
>it stops displaying suggestions for WebView methods and ultimately
>crashes.
>
>--
>Regards,
>Alex
>_______________________________________________
>Mono-osx mailing list
>Mono-osx at lists.ximian.com
>http://lists.ximian.com/mailman/listinfo/mono-osx




More information about the Mono-osx mailing list