[Mono-list] [Mono-dev] Removing NET_2_0 define

[Stifu]

Well, it *is* progress on the source code, although binaries aren't be
affected.
IMHO, the small history noise is totally worth it. Source code control
systems are not supposed to be hindrances that prevent or discourage us from
making wanted code changes, no matter how minor.

A while ago, Miguel and myself did the same thing (removing #if checks) on
WinForms, for what it's worth.


Rodrigo Kumpera wrote
> No, it's just that doing such work doesn't produce progress. But, OTOH, if
> anyone would like to work on such thing, I would not mind
> 
> 
> On Fri, Oct 18, 2013 at 10:55 AM, Alexander Köplinger <

> alex.koeplinger@

>> wrote:
> 
>>  I understand that, so the concern is that having a single commit that
>> changes “many” files is a problem when looking at the history?
>>
>>
>> *Von:* Rodrigo Kumpera <

> kumpera@

> >
>> *Gesendet:* Freitag, 18. Oktober 2013 16:40
>> *An:* Alexander Köplinger <

> alex.koeplinger@

> >
>> *Cc:* 

> jonpryor@

>>
>> We value the commit history as much as the current codebase. When
>> troubleshooting mono, having a neat and simple history is of extreme
>> value.
>>
>>
>> On Fri, Oct 18, 2013 at 10:31 AM, Alexander Köplinger <
>> 

> alex.koeplinger@

>> wrote:
>>
>>>  Ok, then I’ll make a PR.
>>>
>>> @Jonathan: I don’t see why this would generate “commit noise”, for me
>>> the
>>> code base would be far more readable without the #if checks.
>>>
>>> Alex
>>>
>>> *Von:* Rodrigo Kumpera <

> kumpera@

> >
>>> *Gesendet:* Freitag, 18. Oktober 2013 15:16
>>> *An:* Alexander Köplinger <

> alex.koeplinger@

> >
>>> *Cc:* 

> mono-devel-list at .ximian

>>>
>>> It can be removed. It wasn't done out of laziness.
>>>
>>>
>>> On Wed, Oct 16, 2013 at 10:00 AM, Alexander Köplinger <
>>> 

> alex.koeplinger@

>> wrote:
>>>
>>>> As far as I understand it, Mono now only supports the 2.0 and later
>>>> profiles.****
>>>>
>>>> ** **
>>>>
>>>> Wouldn’t it make sense to remove the #if NET_2_0 checks in the codebase
>>>> as those are now unnecessary (every profile is now 2.0 or later)?****
>>>>
>>>> Or are they actually required for something? If not, I’d provide a pull
>>>> request to clean up those checks.****
>>>>
>>>> ** **
>>>>
>>>> Alex****
>>>>
>>>> ** **
>>>>
>>>> _______________________________________________
>>>> Mono-devel-list mailing list
>>>> 

> Mono-devel-list at .ximian

>>>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>>>>
>>>>
>>>
>>
> 
> _______________________________________________
> Mono-list maillist  -  

> Mono-list at .ximian

> http://lists.ximian.com/mailman/listinfo/mono-list





--
View this message in context: http://mono.1490590.n4.nabble.com/Re-Mono-dev-Removing-NET-2-0-define-tp4661154p4661161.html
Sent from the Mono - General mailing list archive at Nabble.com.