[Mono-list] CollectionBaseTest patch

Nick Drochak ndrochak@gol.com
Mon, 27 May 2002 10:57:23 +0900


Thanks for the patch.  However, I'd like to point out a few things...

1) For AssertEquals(m, x, a) the second parameter (x) is the expected value,
and the third (a) is the actual value.  When they are not equal NUnit gives
you a nice message saying "Expected <x> but got <a>".  If you reverse them,
then  it can be confusing.

2) There's not much point using AssertEquals() over Assert() for Boolean
values, although it's not exactly "wrong". If you do use AssertEquals(),
please keep in mind #1 above.

Those are general comments.  I also have a specific one:

| -		Assert(4 == myCollection.Count);
| +		AssertEquals ("A01", 4, mycollection);

Did you forget the Count property here?

Again, thanks.

Nick D.