[Mono-list] testcase for System.Convert complete...

Nick Drochak ndrochak@gol.com
Fri, 17 May 2002 10:52:01 +0900


| Wonderful job!  I have now included this on the CVS repository, and will
| be running my own test myself this afternoon (Duncan has to help me get
| setup  for that ;-)
|

Yes.  Very nice.  Thanks a lot!

I would suggest adding the Max and Min values as tests as well.  There are
no tests in here using negative numbers at all, so the Min value for some of
those types might prove to be interesting.

Also, the comma/decimal issue is probably culture related.  You can try to
include this code in your SetUp and TearDown (which I grabbed from
Int16Test.cs):

	private CultureInfo old_culture;

	protected override void SetUp()
	{
		old_culture = Thread.CurrentThread.CurrentCulture;

		// Set culture to en-US and don't let the user override.
		Thread.CurrentThread.CurrentCulture = new CultureInfo ("en-US", false);

	}

	protected override void TearDown()
	{
		Thread.CurrentThread.CurrentCulture = old_culture;
	}

I think support for various cultures is somewhat lacking still at this
point.


Thanks again,
Nick D.