[Mono-list] Recent Windows.Forms commit

[John Barnette]

At 01:18 PM 4/3/2002, Dan Lewis wrote:
>  --- John Barnette <jbarn@httcb.net> wrote: >
> > 1. The standard operating procedure for directory structure is
> >     "class/[assembly]/[namespace]", so source files should actually live in
> >     "class/System.Windows.Forms/System.Windows.Forms".  I know it looks 
> odd,
> >     but consistency is a Good Thing (TM).
> >
> > 2. Please break out each enum in enums.cs into a separate source file.
> >     while the enums are quite small, having public types in separate
> >     files is another standard operating procedure.  So, the following 
> should
> >     be created in mcs/class/System.Windows.Forms/System.Windows.Forms:
>
>Hmm, I need to break up the RegularExpressions namespace too. But on top 
>of the
>public classes I've also got about 40 internal classes, and a private 
>namespace
>RegularExpressions.Syntax (some of the syntax tree names clashed with the
>public names). Any idea what to do with these? Can I just leave them in their
>own files?

Yo Rx,

If I were you, I'd move each type into a separate file, regardless of 
visibility.  I'd also create directories under the assembly for any private 
namespaces.

When it comes to private implementation details like this, it really seems 
like a matter of author opinion, so I fully expect you ignore my 
suggestions. ;-)


~ j.