[Mono-list] Recent Windows.Forms commit

[John Barnette]

 > Module name: mcs
 > Changes by: dennis 02/04/03 10:17:57
 > Added files:
 > class/System.Windows.Forms: enums.cs
 > Log message:
 > * A stake in the ground *
 > * enums from A to C *
 > * System.Windows.Forms is open for development *

Hi Dennis,

I hope you're reading the list, since I don't have your email address.

Way to go starting on the Windows.Forms stubbing!  I'd like to suggest a 
few things before you commit anything else:

1. The standard operating procedure for directory structure is
    "class/[assembly]/[namespace]", so source files should actually live in
    "class/System.Windows.Forms/System.Windows.Forms".  I know it looks odd,
    but consistency is a Good Thing (TM).

2. Please break out each enum in enums.cs into a separate source file.
    while the enums are quite small, having public types in separate
    files is another standard operating procedure.  So, the following should
    be created in mcs/class/System.Windows.Forms/System.Windows.Forms:

       AccessibleEvents.cs
       AccessibleEvents.cs
       AccessibleRole.cs
       AccessibleStates.cs
       AnchorStyles.cs
       Appearance.cs
       ArrangeDirection.cs
       ArrangeStartingPosition.cs
       BootMode.cs
       Border3DSide.cs
       Border3DStyle.cs
       BorderStyle.cs
       BoundsSpecified.cs
       ButtonBorderStyle.cs
       ButtonState.cs
       ColorDepth.cs
       ColumnHeaderStyle.cs
       ComboBoxStyle.cs
       ControlStyles.cs
       DataGridLineStyle.cs
       DateTimePickerFormat.cs
       Day.cs

Thanks!


~ j.