[Mono-docs-list] Monodoc print support patch - feedback needed.

Mario Sopena mario.sopena at gmail.com
Thu Sep 8 11:13:58 EDT 2005


On 9/6/05, Rafael Ferreira <lists at ophion.org> wrote:
> Mario,
> here's the updated patch. It took me some time to get this to you
> because I updated my docbrowser and monodoc sources so I had to merge
> the printing patch upstream. This time I basically edited the
> browser.glade file by hand, adding only the needed entries.
> Let me know what you could use a hand with next.

I took your patch and worked a little bit with it. This are the things
I've changed:

- Since we already have an abstraction for separing Gecko and GtkHTML
with IHtmlRender and the two implementations (Gtk and Gecko), I've
moved all the printing logic to them, so we can get rif of
IPrintManager and GtkHTMLPrintManager. I do think is more sane now. I
have used a Print method only with a parameter, the html code, because
when using css, the html code returned by the HelpSource already has
the css.

- The print menu item is only clickable when you are not editing a node

- I've encountered problems because the two kinds of Url presents in
monodoc (with your patch, the browser crashed when printing a node
which was accesed through the treeview). I think now it works.

- The ecma provider was not tracking well the use_css variable. Now,
it will print the html according to it. (For the moment, everything
without css)

- I've left out the thing with gnome-stock-about and gtk-about because
I'm not sure it's really important now, try to open a bug in bugzilla.

By the way, I think the monodoc section of bugzilla is forgoten and
unmaintained. Miguel, can you give me permission to deal with it?


-------------- next part --------------
A non-text attachment was scrubbed...
Name: browser.diff
Type: text/x-patch
Size: 1826 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-docs-list/attachments/20050908/856a9132/browser.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: docbrowser.diff
Type: text/x-patch
Size: 7500 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-docs-list/attachments/20050908/856a9132/docbrowser.bin

More information about the Mono-docs-list mailing list