[Mono-docs-list] Monodoc print support patch - feedback needed.

[Rafael Ferreira]

Mario, 

here's the updated patch. It took me some time to get this to you
because I updated my docbrowser and monodoc sources so I had to merge
the printing patch upstream. This time I basically edited the
browser.glade file by hand, adding only the needed entries. 

Let me know what you could use a hand with next. 

- raf


On Mon, 2005-09-05 at 18:08 +0200, Mario Sopena wrote:
> Hello Rafa,
> 
> > I have no clue what those "ellipsize" glade tags are. I played around
> > with glade for a while to see if I could remove those with no luck.
> > Aside from manually editing the xml I have no idea how to make them go
> > away. But to answer your question, the only other change I made to this
> I usually remove the lines of the patch (it easier than editing the
> xml) and then apply the patch to an unmodified version of the file
> (you can revert your changes with svn revert file). But is up to you
> how to do that. However, those lines should be kept away.
> 
> > file (besides adding the gtk-stock-print menu item) is to enforce that
> > the About menu item is using the gtk-stock-about icon. Originally
> > FC4/Clearlooks was having problems saving the glade file because it
> > could not find the About icon.
> 
> I think the change you refer is this one:
> -			  <property name="stock">gnome-stock-about</property>
> +			  <property name="stock">gtk-about</property>
> 
> but there is also a lot of things like:
> -			<widget class="GtkImage" id="image132">
> +			<widget class="GtkImage" id="image141">
> or
> -			<widget class="GtkImage" id="image119">
> +			<widget class="GtkImage" id="image139">
> or
> -			<widget class="GtkImage" id="image118">
> +			<widget class="GtkImage" id="image138">
> 
> that I'm not sure what are doing, so I prefer to leave them out.
> Please, send me (and to the monodoc list) a mail with an updated patch
> so I can send it to SVN.
> 
> Thanks for your work.
> Mario
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: docbrowser.patch
Type: text/x-patch
Size: 5547 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-docs-list/attachments/20050905/6ad53a82/docbrowser.bin