[Mono-docs-list] MonoDoc type lookups / helpsource improvement

[Miguel de Icaza]

Hello,

> > And attached is a patch to correct that bug and other related member 
> > lookup bugs.  Applying the patch will allow N, T, M, F, P, E, and C: 
> > lookups to work.  (For members, it actually doesn't matter what letter 
> > is used in the URL out of M F P E and C.)  I'll commit it once I get the 
> > nod.
> 
> I'm coming in a bit late on this, but.... Shouldn't all ecma doc related
> stuff be in ecma-provider.cs? If I understand the browser code,
> Provider.cs should ideally just be a generic class that all providers
> (regardless of their content domain) should  extend? 

Well, the "Type" lookup system is important enough that it merited
support at the core.  Support that gets mostly relayed to ecma-provider.

> Unless I've misunderstood the code, I think it would be really nice to
> factor out all the ecma-specific stuff from provider.cs? Things like
> MemberLookup, TypeLookup etc, are all meaningless to an XHtml provider.
> Which means when I'm implementing the XHtml provider, extending from a
> class (provider.cs) that has all sorts of language doc features feels
> like a weird abstraction...

Remember that the ECMA provider is only one of the type providers.  It
happens to be the most convenient for us to use today;  But there are
other providers which we need that will require this: the C# XML one for
example.

> Should hopefully have a patch ready for inspection tonight for the Xhtml
> provider - still don't handle embedded images yet, but it works enough
> to be useful. I think. :)

It might be time to make a new release with all this new material! :-)

Miguel