[Mono-dev] Review of PR1349

Martin Thwaites monoforum at my2cents.co.uk
Fri Oct 17 21:35:06 UTC 2014

Thanks Chris,

The main thing I think will be off benefit with people reviewing is simply
getting that second pair of eyes to sanity check it.  Looking for basic
coding standards stuff, anything obvious.  Other things like advice on
separating things out etc.

On 17 October 2014 20:46, Chris Rogus <cricel472 at gmail.com> wrote:

> Disclaimer: I know nothing about these classes.
> That said, I firmly support the plan to bring PRs into the mailing list,
> and would hate to see such a great plan get no love, so I want to say that
> from looking at these (very small and easily digested) changes, they at
> least look clean and good.
> From a fellow user of Mono who is interested in its success and expansion
> (with no say in any outcomes here), thanks for doing this.
> On Oct 16, 2014 6:23 PM, "Martin Thwaites" <monoforum at my2cents.co.uk>
> wrote:
>> Hi all,
>> I've just put up my attempt at getting the MachineKey.Protect and
>> Unprotect methods available in mono.  I'd be grateful if someone give it a
>> quick review to make sure it makes sense.
>> https://github.com/mono/mono/pull/1349
>> Couple of notes.  There is no compatibility with encrypted items that
>> were done using Windows.  This is a barebones implementation in that it
>> will work and be at least as secure as MachineKey.Encrypt/Decrypt (as it
>> uses the same methods under the hood).
>> This is my first PR for mono, so please be kind.  I've tried my best to
>> follow the coding guidelines, but I'm happy to make changes.
>> Thanks
>> Martin
>> _______________________________________________
>> Mono-devel-list mailing list
>> Mono-devel-list at lists.ximian.com
>> http://lists.ximian.com/mailman/listinfo/mono-devel-list
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/mono-devel-list/attachments/20141017/6ce1ed1a/attachment-0001.html>

More information about the Mono-devel-list mailing list