[Mono-dev] Unit Tests - Do i do a separate commit/push/pull or do i start from scratch

[Rob Wilkens]

After I committed and pushed, I tried to do another pull request, but it 
seemed to merge it into my existing pull request, which i guess is fine.

I'm open to suggestions if anyone doesn't like my pull-request.  Don't 
mean to push the issue, however long it takes is however long it takes.

I am well aware that it could be quite some time before this patch 
reaches my local system via packaging..  There is probably a review 
process before you accept it or not, some time before the next version 
is released, and some time beyond that before ubuntu releases an updated 
package which includes it.

-Rob

On 05/03/2012 07:46 AM, Rodrigo Kumpera wrote:
> Separate is fine. Tests are always welcome.
>
> Thanks for taking time on this.
>
>
> On Wed, May 2, 2012 at 11:10 PM, Rob Wilkens <robwilkens at gmail.com 
> <mailto:robwilkens at gmail.com>> wrote:
>
>     I came up with a Nunit test that :
>     (1) Demonstrates the failure i reported
>     (2) Demonstrates that it is fixed with my patch
>
>     (My git directory is separate from my build directory)
>
>     My plan, if i remember tomorrow, is to commit this change to
>     github, push it, and do another pull request.
>
>     Do i need to incorporate it into the same pull request as the fix
>     itself, or is it ok to do the tests as a separate commit/pull request?
>
>     If i don't hear back, i'll just assume separate is ok.
>     _______________________________________________
>     Mono-devel-list mailing list
>     Mono-devel-list at lists.ximian.com
>     <mailto:Mono-devel-list at lists.ximian.com>
>     http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/mono-devel-list/attachments/20120503/6de2ce0a/attachment.html>