[Mono-dev] Unit Tests - Do i do a separate commit/push/pull or do i start from scratch

[Rodrigo Kumpera]

Separate is fine. Tests are always welcome.

Thanks for taking time on this.


On Wed, May 2, 2012 at 11:10 PM, Rob Wilkens <robwilkens at gmail.com> wrote:

> I came up with a Nunit test that :
> (1) Demonstrates the failure i reported
> (2) Demonstrates that it is fixed with my patch
>
> (My git directory is separate from my build directory)
>
> My plan, if i remember tomorrow, is to commit this change to github, push
> it, and do another pull request.
>
> Do i need to incorporate it into the same pull request as the fix itself,
> or is it ok to do the tests as a separate commit/pull request?
>
> If i don't hear back, i'll just assume separate is ok.
> ______________________________**_________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.**com <Mono-devel-list at lists.ximian.com>
> http://lists.ximian.com/**mailman/listinfo/mono-devel-**list<http://lists.ximian.com/mailman/listinfo/mono-devel-list>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ximian.com/pipermail/mono-devel-list/attachments/20120503/7155cd03/attachment.html>