[Mono-dev] Finalizers in CriticalHandle

[Rodrigo Kumpera]

Patch looks good to me.

On Sat, Jan 22, 2011 at 6:09 AM, Gonzalo Paniagua Javier <
gonzalo.mono at gmail.com> wrote:

> On Thu, 2011-01-20 at 16:15 +0000, Dick Porter wrote:
> > On 17 Jan 2011, at 6:00PM, Rodrigo Kumpera wrote:
> > > I'm not sure what the defined behavior is on this case, MSDN is not
> > > always accurate and we
> > > need to be as compatible with MS as possible.
> > >
> > > Could you please write a test case, and if the behavior you suggest
> > > is correct, send a patch
> > > which includes both the fix and the test case so we can move forward?
> >
> > Please see attached test case and diff.
>
> I think a more correct patch would be the one attached. Avoids having
> 'if (Invalid) return;' followed by 'if (!Invalid)...'.
>
> -Gonzalo
>
>
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20110122/630483d7/attachment.html