[Mono-dev] Finalizers in CriticalHandle

[Gonzalo Paniagua Javier]

On Thu, 2011-01-20 at 16:15 +0000, Dick Porter wrote:
> On 17 Jan 2011, at 6:00PM, Rodrigo Kumpera wrote:
> > I'm not sure what the defined behavior is on this case, MSDN is not  
> > always accurate and we
> > need to be as compatible with MS as possible.
> >
> > Could you please write a test case, and if the behavior you suggest  
> > is correct, send a patch
> > which includes both the fix and the test case so we can move forward?
> 
> Please see attached test case and diff.

I think a more correct patch would be the one attached. Avoids having
'if (Invalid) return;' followed by 'if (!Invalid)...'.

-Gonzalo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: critical-handle.patch
Type: text/x-patch
Size: 801 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20110122/137e2286/attachment.bin