[Mono-dev] Mono Winforms on Mac (Carbon) fixes - all my source code changes attached
gnorton at novell.com
Fri Oct 8 00:26:27 EDT 2010
On 2010-10-07, at 9:33 PM, Bojan Rajkovic wrote:
> Hi Ralph,
> This sounds really cool, but my bet is that the WinForms maintainer is going to want to see it as smaller patch chunks, and preferably without whitespace/formatting changes (which it sounds like you have if you used Visual Studio's Format Document feature).
Yes, this would be ideal, I've done a diff -w -u -r and there is a lot of noise in the patch, making it very difficult to seperate the signal.
> You may want to also fork Mono on Github and apply these patches to your fork (make the patch applications atomic, commit often, and document the commits appropriately), then send a pull request. In my experience, pull requests make it easier for the team to review what's changed and decide whether it's good to apply.
This would be ideal.
> Of course, my opinions are not those of the WinForms maintainer, who may be happy to take your code as is—definitely wait for them before doing anything drastic.
> On Oct 7, 2010, at 12:56 PM, Ralph Leckett wrote:
>> Hi All,
>> Attached is a zip file of 54 classes that I modified to get Mono
>> Winforms on Mac Carbon working with my .net application from hell. My
>> apologies for using MS Visual Studio's "Format Document" on all of
>> Ralph Leckett
>> Mono-devel-list mailing list
>> Mono-devel-list at lists.ximian.com
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
More information about the Mono-devel-list