[Mono-dev] Mono Winforms on Mac (Carbon) fixes - all my source code changes attached

[Bojan Rajkovic]

Hi Ralph,

This sounds really cool, but my bet is that the WinForms maintainer is going to want to see it as smaller patch chunks, and preferably without whitespace/formatting changes (which it sounds like you have if you used Visual Studio's Format Document feature). 

You may want to also fork Mono on Github and apply these patches to your fork (make the patch applications atomic, commit often, and document the commits appropriately), then send a pull request. In my experience, pull requests make it easier for the team to review what's changed and decide whether it's good to apply.

Of course, my opinions are not those of the WinForms maintainer, who may be happy to take your code as is—definitely wait for them before doing anything drastic.

Regards,
Bojan

On Oct 7, 2010, at 12:56 PM, Ralph Leckett wrote:

> Hi All,
> 
> Attached is a zip file of 54 classes that I modified to get Mono
> Winforms on Mac Carbon working with my .net application from hell. My
> apologies for using MS Visual Studio's "Format Document" on all of
> them.
> 
> Ralph Leckett
> <MonoLibs-Diff.zip>_______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list