[Mono-dev] [PATCH] Add XAttribute's missing DateTimeOffset operators, with tests

Atsushi Eno atsushieno at veritas-vos-liberabit.com
Fri Jan 15 05:56:50 EST 2010


Thanks for the massive tests again. All test failures are now fixed in 
trunk :)
I'll backport the changes later.

Atsushi Eno

On 2010/01/15 10:09, Tiaan Geldenhuys wrote:
> [Resending with one attachment compressed, due to mailing-list's size
> restrictions.]
> This is probably again for Atsushi:
> Similar to the last round with XElement, but now for XAttribute, the
> attached patch adds the latter's missing DateTimeOffset operators.  The
> extra tests only compile under Mono after applying the patch and now include
> test-cases for XAttribute that are similar to those for XElement; all pass
> under .NET, but some of the code underlying the casting operators may still
> need fixing for Mono.  The tests also expand on what was previously testable
> under Mono, and there is one particularly interesting case where about 1 of
> every 8 DateTime values would lose a tick: it looks like a weird
> rounding-error and can now be reproduced reliably with these tests.
> Atsushi's patches from earlier this week already made a huge difference, and
> getting the new tests to work should make for an even more robust
> LINQ-to-XML implementation.
> Please commit the patches and investigate the new tests that fail.
> Thank you,
> Tiaan.

More information about the Mono-devel-list mailing list