[Mono-dev] [PATCH] Add XAttribute's missing DateTimeOffset operators, with tests

Tiaan Geldenhuys tagdev at gmail.com
Thu Jan 14 20:09:48 EST 2010

[Resending with one attachment compressed, due to mailing-list's size

This is probably again for Atsushi:

Similar to the last round with XElement, but now for XAttribute, the
attached patch adds the latter's missing DateTimeOffset operators.  The
extra tests only compile under Mono after applying the patch and now include
test-cases for XAttribute that are similar to those for XElement; all pass
under .NET, but some of the code underlying the casting operators may still
need fixing for Mono.  The tests also expand on what was previously testable
under Mono, and there is one particularly interesting case where about 1 of
every 8 DateTime values would lose a tick: it looks like a weird
rounding-error and can now be reproduced reliably with these tests.
Atsushi's patches from earlier this week already made a huge difference, and
getting the new tests to work should make for an even more robust
LINQ-to-XML implementation.

Please commit the patches and investigate the new tests that fail.

Thank you,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: System-Xml-Linq-XAttribute_DateTimeOffset-operators_mcs-class-trunk.patch
Type: application/octet-stream
Size: 1020 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20100114/9cb07649/attachment.obj 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MonoTests-System-Xml-Linq_type-cast-operators_mcs-class-trunk.patch.gz
Type: application/x-gzip
Size: 9844 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20100114/9cb07649/attachment.gz 

More information about the Mono-devel-list mailing list