[Mono-dev] marshal.c changed to fix minimal build with cominterop disabled mistake - #ifdef DISABLE_COM instead of #ifndef DISABLE_COM

[Rodrigo Kumpera]

On Wed, Sep 2, 2009 at 3:50 PM, Tom Hindle <tom_hindle at sil.org> wrote:

> in this change:
>
>
> this breaks our application - can anyone let me know why this was done?
>
>

Sure, I screwed it up in trying to enable disable_com. r141169 should fix
it.

It was done this way pretty much because there isn't a test suite for com
interop.
Did we have such thing, my stupid mistake would have been caught up half
month
ago and it would have caused you no harm.

Guys, if you really care about COM interop on mono, do you mind putting up a
test
suite so the others can change such code not been blind-folded? Bugs caught
by
automated tests are noticed and fixed in a much more orderly and timely
fashion.

Cheers,
Rodrigo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090902/1567cb16/attachment.html