[Mono-dev] FileInfo Replace

[Miguel de Icaza]

Hello David, Max,

    David, thanks for the contribution!

    I appreciate that it included some great tests as part of the
contribution.

    Max, thanks for reviewing the code and providing feedback.

Miguel.

> 
> Ok this check first the read-only flag and sends and exception if the
> destinationFileName is has it.
> 
> On Sat, May 2, 2009 at 12:59 PM, David Uvalle <david.uvalle at gmail.com>
> wrote:
>         
>         On Fri, May 1, 2009 at 5:18 PM, Max de Lavenne <max at tfbc.com>
>         wrote:
>                 Nice,
>                  
>                 But... you need to also check for the read-only flag
>                 of the destinationFileName before copying. Especially
>                 important for Linux systems where IsReadOnly isn't the
>                 only parameter to check
>         
>         What are the others? e.g. that the destinationFileName is in a
>         path where a user don't have permission to write?
>          
>                 
>                  
>                 Quote from MSDN "This method will succeed in Windows
>                 2000 environments if the destFileName is read-only and
>                 will not raise an exception. Use the IsReadOnly
>                 property to check if the destination file is read-only
>                 before attempting to replace it."
>                  
>                 You should implement that.
>         
>         Sure I will.
>         
>         Thanks for your feedback.
>         
>          
>                 
>                 
>                 
>                 ______________________________________________________
>                 From: mono-devel-list-bounces at lists.ximian.com
>                 [mailto:mono-devel-list-bounces at lists.ximian.com] On
>                 Behalf Of David Uvalle
>                 Sent: Friday, May 01, 2009 3:10 PM
>                 To: mono-devel-list
>                 Subject: [Mono-dev] FileInfo Replace
>                 
>                 
>                 
>                 FileInfo Replace method and some tests.
>                 
>         
> 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list