[Mono-dev] Compiler warnings

[Miguel de Icaza]

Hello,

    One last thing;   Please either sign a copyright assignment form or
state that the patches are under the MIT X11 license as it is not a
small patch.
 
> Round 2,
> 
>   * Moved TEMP_FAILURE_RETRY macro to mono/utils/mono-io-portability.h.
>   * Removed #ifndef PLATFORM_MACOSX for now.
> 
> -- Christian
> 
> 
> 
> On Jul 23, 2009, at 8:24 PM, Geoff Norton wrote:
> 
> > On 23-Jul-09, at 11:02 PM, Christian Hergert wrote:
> >
> >> Hello,
> >>
> >> In an effort to get more familiar with some of the code-base, I  
> >> went through and fixed some of the pesky compiler warnings for the  
> >> runtime.  Attached is a patch for said warnings.
> >>
> >> If anyone has suggestions on how to better fix the warnings, please  
> >> send them my way and I'll adjust the patch as needed.
> >>
> >
> > #1: Having tons of
> > +#ifndef TEMP_FAILURE_RETRY
> >
> > is sucky, localize it into mono/utils/somewhere-logical.h and  
> > include it around
> >
> >
> > #2: lots of:
> > +#ifndef PLATFORM_MACOSX
> > 	FILE *fp;
> > +#endif
> >
> > impedes readability (for me) just for 1 platform, not sure its worth  
> > it.
> >
> > As for the rest, it looks sane, but I'll let the runtime guys weigh  
> > in.
> >
> > -g
> >
> 
> _______________________________________________
> Mono-devel-list mailing list
> Mono-devel-list at lists.ximian.com
> http://lists.ximian.com/mailman/listinfo/mono-devel-list