[Mono-dev] Compiler warnings

[Christian Hergert]

Round 2,

  * Moved TEMP_FAILURE_RETRY macro to mono/utils/mono-io-portability.h.
  * Removed #ifndef PLATFORM_MACOSX for now.

-- Christian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: mono-fix-compiler-warnings-2.patch
Type: application/octet-stream
Size: 22557 bytes
Desc: not available
Url : http://lists.ximian.com/pipermail/mono-devel-list/attachments/20090723/47f3d96c/attachment-0001.obj 
-------------- next part --------------



On Jul 23, 2009, at 8:24 PM, Geoff Norton wrote:

> On 23-Jul-09, at 11:02 PM, Christian Hergert wrote:
>
>> Hello,
>>
>> In an effort to get more familiar with some of the code-base, I  
>> went through and fixed some of the pesky compiler warnings for the  
>> runtime.  Attached is a patch for said warnings.
>>
>> If anyone has suggestions on how to better fix the warnings, please  
>> send them my way and I'll adjust the patch as needed.
>>
>
> #1: Having tons of
> +#ifndef TEMP_FAILURE_RETRY
>
> is sucky, localize it into mono/utils/somewhere-logical.h and  
> include it around
>
>
> #2: lots of:
> +#ifndef PLATFORM_MACOSX
> 	FILE *fp;
> +#endif
>
> impedes readability (for me) just for 1 platform, not sure its worth  
> it.
>
> As for the rest, it looks sane, but I'll let the runtime guys weigh  
> in.
>
> -g
>